ianmcook commented on a change in pull request #10190:
URL: https://github.com/apache/arrow/pull/10190#discussion_r622509689
##########
File path: r/R/compute.R
##########
@@ -284,3 +284,14 @@ cast_options <- function(safe = TRUE, ...) {
)
modifyList(opts, list(...))
}
+
+#' @export
+strsplit <- function(x, split, fixed = TRUE, perl = FALSE, useBytes = FALSE,
...) UseMethod("strsplit")
+
+#' @export
+strsplit.default <- base::strsplit
+
+#' @export
+strsplit.ArrowDatum <- function(x, split, fixed = TRUE, perl = FALSE, useBytes
= FALSE, ...){
Review comment:
I think we should use `fixed = FALSE` in the arguments for consistency
with `base::strsplit()`. Then the code here should throw an error unless
`fixed` is `TRUE`. So the user will need to specify `fixed = TRUE` for it to
work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
