nealrichardson commented on a change in pull request #10190:
URL: https://github.com/apache/arrow/pull/10190#discussion_r622517752
##########
File path: r/R/compute.R
##########
@@ -284,3 +284,14 @@ cast_options <- function(safe = TRUE, ...) {
)
modifyList(opts, list(...))
}
+
+#' @export
+strsplit <- function(x, split, fixed = TRUE, perl = FALSE, useBytes = FALSE,
...) UseMethod("strsplit")
+
+#' @export
+strsplit.default <- base::strsplit
+
+#' @export
+strsplit.ArrowDatum <- function(x, split, fixed = TRUE, perl = FALSE, useBytes
= FALSE, ...){
Review comment:
`fixed = FALSE` doesn't work? Is that a separate regex version, not yet
implemented in C++? (If so, please make a jira for it).
Assuming that's the case, can we still support `fixed = FALSE` as long as
`split` is not a regexp special character? For example, `strsplit("The quick
brown fox", " ")` is identical whether or not you do `fixed = TRUE` or `FALSE`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
