ianmcook commented on a change in pull request #10190:
URL: https://github.com/apache/arrow/pull/10190#discussion_r622528662
##########
File path: r/R/compute.R
##########
@@ -284,3 +284,14 @@ cast_options <- function(safe = TRUE, ...) {
)
modifyList(opts, list(...))
}
+
+#' @export
+strsplit <- function(x, split, fixed = TRUE, perl = FALSE, useBytes = FALSE,
...) UseMethod("strsplit")
+
+#' @export
+strsplit.default <- base::strsplit
+
+#' @export
+strsplit.ArrowDatum <- function(x, split, fixed = TRUE, perl = FALSE, useBytes
= FALSE, ...){
Review comment:
Yep, the splitting on a regex pattern is not implemented in C++.
`split_pattern` was added in https://issues.apache.org/jira/browse/ARROW-9991
and it's strictly for literal strings; there's no RE2 there.
>as long as split is not a regexp special character
The logic to detect that a character string is not a regular expression
could get very, very complicated. But I suppose it would be straightforward to
detect some very obvious cases of not-a-regex. @thisisnic I'm happy to help
with this if you need a hand!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
