scovich commented on PR #9272:
URL: https://github.com/apache/arrow-rs/pull/9272#issuecomment-3808207352
Ok, rebased now that the three prefactor PR merged. The diff looks big, but
the bulk of it is tests and doc comments. The actual change is pretty small.
The biggest single contributors are:
* 800+ LoC for the various motivating examples/tests in
custom_decoder_tests.rs
* Hopefully they're easily understood and help spur a healthy discussion
on what the API should actually look like
* TBD whether they stay as tests for now, or if some are deemed useful
enough to become part of the API
* ~280 LoC to define the variant decoder and factory (+ tests)
* Could potentially split out to a separate PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
