tustvold commented on code in PR #9272:
URL: https://github.com/apache/arrow-rs/pull/9272#discussion_r2735647557
##########
arrow-json/src/lib.rs:
##########
@@ -86,7 +86,7 @@
pub mod reader;
pub mod writer;
-pub use self::reader::{Reader, ReaderBuilder};
+pub use self::reader::{ArrayDecoder, DecoderFactory, Reader, ReaderBuilder,
Tape, TapeElement};
Review Comment:
I think this is the key part that might be deemed controversial. Is Tape
really a good thing to expose publicly? It's been a while since I wrote it, but
I remember it not being especially friendly as an API, and something that
stands a good chance of being changed in future - e.g. to avoid copying
strings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
