ashdnazg commented on PR #10431: URL: https://github.com/apache/arrow-rs/pull/10431#issuecomment-5090989046
There is another problem though - the function `with_metadata` relies on `private_data` being a `SchemaPrivateData`, which wouldn't be the case if we got this schema from e.g., Java and didn't construct it locally (which should be a valid use for an FFI object). `with_name` currently avoids this by leaking the old name, but if we fixed it not to leak, it would have a similar issue. We might want to make these functions unsafe and not public. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
