bit2swaz commented on PR #10431: URL: https://github.com/apache/arrow-rs/pull/10431#issuecomment-5092239861
alright, made the changes. went with getters + unsafe setters like we talked about on all three structs (`FFI_ArrowArray`, `FFI_ArrowSchema`, `FFI_ArrowArrayStream`) since they all had the same `pub release` hole. only `release` + `private_data` are private now, the rest of the fields stay `pub`. also updated the PR description to match the new approach the `with_metadata` thing ill spin off into its own issue like i mentioned. lmk what you think :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
