bit2swaz commented on PR #10431: URL: https://github.com/apache/arrow-rs/pull/10431#issuecomment-5091872138
ah nice, that settles it then. getters + unsafe setters it is. maps right onto your flow too; read both out, overwrite both, restore on release, and you never have to guess where the struct came from. ill add `release()` / `private_data()` getters and `unsafe set_release()` / `set_private_data()` setters (just plain overwrites since you pull the originals out first and own them from there). same on `FFI_ArrowArray` also, good one pointing out the `with_metadata`. its already live on the safe api and a foreign schema's `private_data` ismt a `SchemaPrivateData` so that cast is straight up UB. it is its own thing tho and fixing it changes the safe/unsafe surface of `with_metadata` + `with_name` so i dont wanna bundle it in here and hold up the field change. gonna spin off a separate issue and link back to this thread. that alright with you? anyways, appreciate you hopping in on this :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
