emilk commented on code in PR #10656:
URL: https://github.com/apache/arrow-rs/pull/10656#discussion_r3766413260
##########
arrow-array/src/array/byte_array.rs:
##########
@@ -214,6 +214,9 @@ impl<T: ByteArrayType> GenericByteArray<T> {
}
/// Creates a [`GenericByteArray`] based on an iterator of values without
nulls
+ ///
+ /// # Panics
+ /// Panics if the iterator has no upper bound on its size hint
Review Comment:
Good catch, added: the section now also covers the total value length
exceeding `T::Offset::MAX`.
— Claude
##########
arrow-schema/src/ffi.rs:
##########
@@ -348,6 +360,10 @@ impl FFI_ArrowSchema {
}
/// Returns the metadata in the schema as `Key-Value` pairs
+ ///
+ /// # Panics
+ ///
+ /// Panics if the metadata blob declares more entries than fit in `usize`
Review Comment:
Agreed, removed. A non-negative `i32` always fits in `usize`, and the
negative case returns an error before that point.
— Claude
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
