emilk commented on code in PR #10656:
URL: https://github.com/apache/arrow-rs/pull/10656#discussion_r3766412630
##########
arrow-buffer/src/builder/boolean.rs:
##########
@@ -80,6 +84,10 @@ impl BooleanBufferBuilder {
}
/// Sets a bit in the buffer at `index`
+ ///
+ /// # Panics
+ ///
+ /// Panics if `index` is beyond the end of the underlying buffer
Review Comment:
Switched to `Panics if `index / 8 >= self.as_slice().len()``, which is what
the `bit_util` call actually checks (the buffer can be longer than `len`).
— Claude
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
