emilk commented on code in PR #10656:
URL: https://github.com/apache/arrow-rs/pull/10656#discussion_r3773185306
##########
arrow-array/src/array/byte_array.rs:
##########
Review Comment:
I agree - but I didn't want to change behavior in this PR
##########
arrow-array/src/builder/generic_bytes_view_builder.rs:
##########
@@ -296,8 +300,12 @@ impl<T: ByteViewType + ?Sized> GenericByteViewBuilder<T> {
}
/// Returns the value at the given index
+ ///
/// Useful if we want to know what value has been inserted to the builder
- /// The index has to be smaller than `self.len()`, otherwise it will panic
+ ///
+ /// # Panics
+ ///
+ /// Panics unless `index < self.len()`
Review Comment:
I agree - here and everywhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
