emilk commented on code in PR #10656:
URL: https://github.com/apache/arrow-rs/pull/10656#discussion_r3766412939
##########
parquet/src/bloom_filter/mod.rs:
##########
@@ -391,6 +391,10 @@ impl Sbbf {
/// Create a new [Sbbf] with given number of bytes, the exact number of
bytes will be adjusted
/// to the next power of two bounded by [BITSET_MIN_LENGTH] and
[BITSET_MAX_LENGTH].
+ ///
+ /// # Panics
+ ///
+ /// Panics if the adjusted number of bytes is not a multiple of the block
size
Review Comment:
Agreed, removed. `optimal_num_of_bytes` returns a power of two `>=
BITSET_MIN_LENGTH` (32), and `size_of::<Block>()` is also 32, so the assert
cannot fire.
— Claude
##########
arrow-buffer/src/builder/boolean.rs:
##########
@@ -80,6 +84,10 @@ impl BooleanBufferBuilder {
}
/// Sets a bit in the buffer at `index`
+ ///
+ /// # Panics
+ ///
+ /// Panics if `index` is beyond the end of the underlying buffer
Review Comment:
Applied to the other spots too: `BooleanBufferBuilder::{set_bit, get_bit}`
now use the concrete expression, and the two `NullBufferBuilder` methods point
at them instead of describing the bound in prose.
— Claude
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
