emilk commented on code in PR #10730:
URL: https://github.com/apache/arrow-rs/pull/10730#discussion_r3806804888
##########
arrow-schema/src/ffi.rs:
##########
@@ -133,16 +133,21 @@ unsafe extern "C" fn release_schema(schema: *mut
FFI_ArrowSchema) {
impl FFI_ArrowSchema {
/// create a new [`FFI_ArrowSchema`]. This fails if the fields'
- /// [`DataType`] is not supported.
- ///
- /// # Panics
- ///
- /// Panics if `format` contains an interior nul byte
Review Comment:
You mean replace the `# Panics` section with an `# Errors` section? Yes,
that's a good idea
##########
arrow-data/src/transform/mod.rs:
##########
@@ -763,17 +772,15 @@ impl<'a> MutableArrayData<'a> {
/// Extends the in progress array with a region of the input arrays.
///
/// # Panics
- /// This function panics if there is an invalid index,
- /// i.e. `index` >= the number of source arrays,
- /// `end` > the length of the `index`th array,
- /// or the offset type overflows (e.g. more than 2 GiB in a `StringArray`).
+ /// This function panics for the same reasons [`Self::try_extend`] returns
an error:
Review Comment:
Agreed, same in 7215c980a. It now lists the three cases inline: bad index,
bad range, and offset type overflow.
-- Claude
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
