emilk commented on code in PR #10730:
URL: https://github.com/apache/arrow-rs/pull/10730#discussion_r3806824283
##########
arrow-schema/src/ffi.rs:
##########
@@ -133,16 +133,21 @@ unsafe extern "C" fn release_schema(schema: *mut
FFI_ArrowSchema) {
impl FFI_ArrowSchema {
/// create a new [`FFI_ArrowSchema`]. This fails if the fields'
- /// [`DataType`] is not supported.
- ///
- /// # Panics
- ///
- /// Panics if `format` contains an interior nul byte
Review Comment:
Sorry, I misread this the first time round: you meant an `# Errors` section,
not just dropping `# Panics`. Done in 65621ddaa, for every `try_` function this
PR touches:
* `FFI_ArrowSchema::try_new` had the reason in prose, it now has an `#
Errors` section
* `try_binary` said `# Error`, now `# Errors`
* `try_from_trusted_len_iter` did not say what its `Err` meant at all
Left alone, to keep the diff to what this PR is about: the pre-existing
`try_` functions in the same files that also lack `# Errors` (`try_unary`,
`try_unary_mut`, `try_binary_mut`, and the eight `MutableBuffer::try_*` from
#10317). Happy to sweep those too, here or in a follow-up, whichever you prefer.
-- Claude
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
