emilk commented on code in PR #10730:
URL: https://github.com/apache/arrow-rs/pull/10730#discussion_r3806774742
##########
parquet-variant-compute/src/variant_array.rs:
##########
@@ -409,28 +409,28 @@ impl VariantArray {
/// Use `try_value` if you need to handle conversion errors gracefully.
///
/// # Panics
- /// * if the index is out of bounds
- /// * if the array value is null
- /// * if `try_value` returns an error.
+ /// Panics if [`VariantArray::try_value`] returns an error, e.g. if the
index is out of bounds.
Review Comment:
I kept all three rather than just the index, because `value()` also panics
on invalid `metadata`/`value` bytes (which includes reading a null row) and on
a row with conflicting `value` and `typed_value`. Listing only the index would
hide the other two.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
