emilk commented on code in PR #10730:
URL: https://github.com/apache/arrow-rs/pull/10730#discussion_r3809797658
##########
arrow-arith/src/arity.rs:
##########
@@ -273,8 +273,12 @@ where
if a.null_count() == 0 && b.null_count() == 0 {
try_binary_no_nulls(len, a, b, op)
} else {
- let nulls =
- NullBuffer::union(a.logical_nulls().as_ref(),
b.logical_nulls().as_ref()).unwrap();
+ // `null_count` is a physical count, so it can be non-zero for arrays
that
+ // have no logical nulls at all:
+ let Some(nulls) = NullBuffer::union(a.logical_nulls().as_ref(),
b.logical_nulls().as_ref())
Review Comment:
This is an actual bug fix now btw -
`test_try_binary_run_array_logical_nulls` fails on `main` with
assertion `left == right` failed
left: [11, 1, 31]
right: [11, null, 31]
##########
arrow-arith/src/arity.rs:
##########
@@ -273,8 +273,12 @@ where
if a.null_count() == 0 && b.null_count() == 0 {
try_binary_no_nulls(len, a, b, op)
} else {
- let nulls =
- NullBuffer::union(a.logical_nulls().as_ref(),
b.logical_nulls().as_ref()).unwrap();
+ // `null_count` is a physical count, so it can be non-zero for arrays
that
+ // have no logical nulls at all:
+ let Some(nulls) = NullBuffer::union(a.logical_nulls().as_ref(),
b.logical_nulls().as_ref())
Review Comment:
This is an actual bug fix now btw -
`test_try_binary_run_array_logical_nulls` fails on `main` with
```
assertion `left == right` failed
left: [11, 1, 31]
right: [11, null, 31]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
