Copilot commented on code in PR #51685:
URL: https://github.com/apache/arrow/pull/51685#discussion_r4238684514
##########
cpp/src/parquet/column_writer.h:
##########
@@ -127,10 +131,10 @@ class PARQUET_EXPORT ColumnWriter {
public:
virtual ~ColumnWriter() = default;
- static std::shared_ptr<ColumnWriter> Make(ColumnChunkMetaDataBuilder*,
- std::unique_ptr<PageWriter>,
- const WriterProperties* properties,
- BloomFilter* bloom_filter =
NULLPTR);
+ static std::shared_ptr<ColumnWriter> Make(
+ ColumnChunkMetaDataBuilder*, std::unique_ptr<PageWriter>,
+ const WriterProperties* properties, BloomFilter* bloom_filter = NULLPTR,
+ internal::ContentDefinedChunker* content_defined_chunker = NULLPTR);
Review Comment:
The exported declaration still replaces the existing four-argument `Make`
symbol, so binaries compiled against the current API cannot link, and source
callers using CDC now pass null and throw. Please keep the original public
factory (including its owned-chunker behavior) and route the file writer
through a separate internal overload/factory that accepts the persistent
chunker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
