kszucs commented on code in PR #51685:
URL: https://github.com/apache/arrow/pull/51685#discussion_r4246230740
##########
cpp/src/parquet/column_writer.h:
##########
@@ -127,10 +131,10 @@ class PARQUET_EXPORT ColumnWriter {
public:
virtual ~ColumnWriter() = default;
- static std::shared_ptr<ColumnWriter> Make(ColumnChunkMetaDataBuilder*,
- std::unique_ptr<PageWriter>,
- const WriterProperties* properties,
- BloomFilter* bloom_filter =
NULLPTR);
+ static std::shared_ptr<ColumnWriter> Make(
+ ColumnChunkMetaDataBuilder*, std::unique_ptr<PageWriter>,
+ const WriterProperties* properties, BloomFilter* bloom_filter = NULLPTR,
+ internal::ContentDefinedChunker* content_defined_chunker = NULLPTR);
Review Comment:
To correct my earlier comparison: `::arrow::internal::Executor` is declared
in the installed `arrow/util/thread_pool.h`, so users can create one (e.g. via
[`ThreadPool::Make()`](https://github.com/apache/arrow/blob/5ef3c5200359bc8e2375daf5f989369b0c8c089b/cpp/src/arrow/util/thread_pool.h#L449));
`internal` there only means it has no stability guarantee.
`ContentDefinedChunker` lives in `chunker_internal.h`, which isn't installed,
so users couldn't construct one at all. That's another reason to keep it in the
private overload.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
