kszucs commented on code in PR #51685:
URL: https://github.com/apache/arrow/pull/51685#discussion_r4246207101
##########
cpp/src/parquet/column_writer.h:
##########
@@ -127,10 +131,10 @@ class PARQUET_EXPORT ColumnWriter {
public:
virtual ~ColumnWriter() = default;
- static std::shared_ptr<ColumnWriter> Make(ColumnChunkMetaDataBuilder*,
- std::unique_ptr<PageWriter>,
- const WriterProperties* properties,
- BloomFilter* bloom_filter =
NULLPTR);
+ static std::shared_ptr<ColumnWriter> Make(
+ ColumnChunkMetaDataBuilder*, std::unique_ptr<PageWriter>,
+ const WriterProperties* properties, BloomFilter* bloom_filter = NULLPTR,
+ internal::ContentDefinedChunker* content_defined_chunker = NULLPTR);
Review Comment:
I moved the chunker to a private `ColumnWriter::Make()` overload:
- The public `Make()` stays unchanged, so there's no API or ABI break.
- `ContentDefinedChunker` lives in `chunker_internal.h`, which isn't
installed, so it shouldn't appear in a public signature that users can't even
include.
- Once CDC becomes a public feature, the private overload can be removed,
and the chunker can be added to the public `Make()` with a proper public type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
