kszucs commented on code in PR #51685:
URL: https://github.com/apache/arrow/pull/51685#discussion_r4246101874
##########
cpp/src/parquet/column_writer.h:
##########
@@ -127,10 +131,10 @@ class PARQUET_EXPORT ColumnWriter {
public:
virtual ~ColumnWriter() = default;
- static std::shared_ptr<ColumnWriter> Make(ColumnChunkMetaDataBuilder*,
- std::unique_ptr<PageWriter>,
- const WriterProperties* properties,
- BloomFilter* bloom_filter =
NULLPTR);
+ static std::shared_ptr<ColumnWriter> Make(
+ ColumnChunkMetaDataBuilder*, std::unique_ptr<PageWriter>,
+ const WriterProperties* properties, BloomFilter* bloom_filter = NULLPTR,
+ internal::ContentDefinedChunker* content_defined_chunker = NULLPTR);
Review Comment:
`chunker_internal.h` isn't installed (headers matching `internal` are
skipped), so external code can only pass null here; the forward declaration
just lets the file writer pass its chunker.
`ArrowWriterProperties::Builder::set_executor()` already takes an
`::arrow::internal::Executor*` the same way:
https://github.com/apache/arrow/blob/5ef3c5200359bc8e2375daf5f989369b0c8c089b/cpp/src/parquet/properties.h#L1468.
I'd keep the chunker internal, since making it public would commit us to its
API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
