AlenkaF commented on a change in pull request #10519:
URL: https://github.com/apache/arrow/pull/10519#discussion_r654431915
##########
File path: r/tests/testthat/test-dplyr-arrange.R
##########
@@ -139,18 +139,14 @@ test_that("arrange() on integer, double, and character
columns", {
collect(),
tbl
)
- expect_warning(
- expect_equal(
- tbl %>%
- Table$create() %>%
- arrange(abs(int), dbl) %>%
- collect(),
- tbl %>%
- arrange(abs(int), dbl) %>%
- collect()
- ),
- "not supported in Arrow",
- fixed = TRUE
+ expect_equal(
Review comment:
@thisisnic if I understand correctly it should be something in line off:
```R
dummy_function <- function(x){
if(assert_is(x, c("numeric", "integer"))) warning()
x
}
expect_warning(
expect_equal(
tbl %>%
Table$create() %>%
arrange(dummy_function(int), dbl) %>%
collect(),
tbl %>%
arrange(dummy_function(int), dbl) %>%
collect()
),
"not supported in Arrow",
fixed = TRUE
)
```
Does it make sense?
##########
File path: r/tests/testthat/test-dplyr-arrange.R
##########
@@ -139,18 +139,14 @@ test_that("arrange() on integer, double, and character
columns", {
collect(),
tbl
)
- expect_warning(
- expect_equal(
- tbl %>%
- Table$create() %>%
- arrange(abs(int), dbl) %>%
- collect(),
- tbl %>%
- arrange(abs(int), dbl) %>%
- collect()
- ),
- "not supported in Arrow",
- fixed = TRUE
+ expect_equal(
Review comment:
@thisisnic @jonkeane should I put the correction of the `arrange` test -
where a solution needs to be found for confirming the warning - in a separate
issue and we close this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
