ianmcook commented on a change in pull request #10519:
URL: https://github.com/apache/arrow/pull/10519#discussion_r654942449
##########
File path: r/tests/testthat/test-dplyr-arrange.R
##########
@@ -139,18 +139,14 @@ test_that("arrange() on integer, double, and character
columns", {
collect(),
tbl
)
- expect_warning(
- expect_equal(
- tbl %>%
- Table$create() %>%
- arrange(abs(int), dbl) %>%
- collect(),
- tbl %>%
- arrange(abs(int), dbl) %>%
- collect()
- ),
- "not supported in Arrow",
- fixed = TRUE
+ expect_equal(
Review comment:
Oh, I understand now 😄 Sorry for my earlier confusion @AlenkaF!
Here is what I would recommend doing:
1. Remove the test code beginning on line 142, and do not replace it with
anything. As @jonkeane said in the first comment in this thread:
> I'm not certain we really need to have this test since we test that
`abs()` works in test-dplyr.R
I agree with that. Actually, I am certain we do not need to have this
test.
2. Set aside the questions about how best to write tests for unimplemented
functions. As @thisisnic says
>What I had in mind was a more general way of testing functions that
shouldn't work in the dplyr pipelines... However, ... this already seems to
exist
We can revisit that issue separately from this PR, if needed.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
