ianmcook commented on a change in pull request #10519:
URL: https://github.com/apache/arrow/pull/10519#discussion_r654734633
##########
File path: r/tests/testthat/test-dplyr-arrange.R
##########
@@ -139,18 +139,14 @@ test_that("arrange() on integer, double, and character
columns", {
collect(),
tbl
)
- expect_warning(
- expect_equal(
- tbl %>%
- Table$create() %>%
- arrange(abs(int), dbl) %>%
- collect(),
- tbl %>%
- arrange(abs(int), dbl) %>%
- collect()
- ),
- "not supported in Arrow",
- fixed = TRUE
+ expect_equal(
Review comment:
The way `arrange()` works, it should be able to take any valid
expressions as arguments, and assuming we have the translations for all the
functions in the expressions implemented here in the arrow package, it should
work. The `desc()` function is a special case—it is _not_ implemented generally
for other dplyr verbs and it only works within `arrange()`.
So I'm confused; is `arrange(abs(int), dbl))` not working? It should work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
