thisisnic commented on a change in pull request #10519:
URL: https://github.com/apache/arrow/pull/10519#discussion_r654538420
##########
File path: r/tests/testthat/test-dplyr-arrange.R
##########
@@ -139,18 +139,14 @@ test_that("arrange() on integer, double, and character
columns", {
collect(),
tbl
)
- expect_warning(
- expect_equal(
- tbl %>%
- Table$create() %>%
- arrange(abs(int), dbl) %>%
- collect(),
- tbl %>%
- arrange(abs(int), dbl) %>%
- collect()
- ),
- "not supported in Arrow",
- fixed = TRUE
+ expect_equal(
Review comment:
Hi @AlenkaF - I think I owe you an apology!
What I had in mind was a more general way of testing that functions that
shouldn't work in the dplyr pipelines, and the code example I sketched out
myself uses `mutate` and a function similar to yours there but which results in
an error.
However, looking at the tests for `mutate`, this already seems to exist and
just uses a function that we don't implement all the arguments for.
https://github.com/apache/arrow/blob/f1e3c2e557bb3622b203fb270bf0329f53f1e617/r/tests/testthat/test-dplyr-mutate.R#L121-L137
I don't think this actually can be done in `arrange` as `desc` is already
implemented and as far as I'm aware that's the only function you can supply to
`arrange` to change the ordering.
Sorry about that, I appreciate you've spent time looking into this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
