emkornfield commented on a change in pull request #10729:
URL: https://github.com/apache/arrow/pull/10729#discussion_r670962655
##########
File path: cpp/src/parquet/statistics.h
##########
@@ -291,6 +291,9 @@ class TypedStatistics : public Statistics {
/// arrow::BinaryArray
virtual void Update(const ::arrow::Array& values) = 0;
+ virtual void UpdateArrowDictionary(const ::arrow::Array& indices,
Review comment:
can this be moved to the caller instead. It would be nice to try to
avoid more coupling of Arrow with the default parquet library.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
