westonpace commented on a change in pull request #10729:
URL: https://github.com/apache/arrow/pull/10729#discussion_r670979161
##########
File path: cpp/src/parquet/statistics.h
##########
@@ -291,6 +291,9 @@ class TypedStatistics : public Statistics {
/// arrow::BinaryArray
virtual void Update(const ::arrow::Array& values) = 0;
+ virtual void UpdateArrowDictionary(const ::arrow::Array& indices,
Review comment:
I can move the "compute referenced values" logic to the caller so that
statistics.cc doesn't depend on ::arrow::compute but I think I still need a
second Update method here because the null count comes from the indices array
and the min/max from the values array.
Alternatively, I could change the existing Update method to take an optional
null_count parameter (where -1 flags to use the old behavior and grab from the
array). I think I'll do this latter approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
