emkornfield commented on a change in pull request #10729:
URL: https://github.com/apache/arrow/pull/10729#discussion_r671375657
##########
File path: cpp/src/parquet/statistics.h
##########
@@ -291,6 +291,9 @@ class TypedStatistics : public Statistics {
/// arrow::BinaryArray
virtual void Update(const ::arrow::Array& values) = 0;
+ virtual void UpdateArrowDictionary(const ::arrow::Array& indices,
Review comment:
I think making update take an optional null_count parameter actually
makes the most sense. Not sure if you are subscribed to dev@parquet but the
null_count statistics are incorrect for repeated fields
https://issues.apache.org/jira/browse/PARQUET-2067 and I think the fix will
involve passing along the null count as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
