emkornfield commented on a change in pull request #10729:
URL: https://github.com/apache/arrow/pull/10729#discussion_r670964526
##########
File path: cpp/src/parquet/arrow/arrow_reader_writer_test.cc
##########
@@ -3796,6 +3796,95 @@ TEST(TestArrowWriterAdHoc, SchemaMismatch) {
ASSERT_RAISES(Invalid, writer->WriteTable(*tbl, 1));
}
+// ----------------------------------------------------------------------
+// Tests for directly writing DictionaryArray
+class TestArrowWriteDictionary : public ::testing::Test {
+ public:
+ void SetUp() override {
+ properties_ = default_arrow_writer_properties();
+ serialized_data_ = AllocateBuffer();
+ }
+
+ // Generates a range of single character strings from start to end
(inclusive)
+ // Nulls will be inserted starting at index 0. If there are any null
+ // values then start will not be the true min. However, the dictionary
+ // array will always contain all the values even if they aren't all used.
+ void GenerateRange(int num_nulls, char start, char end) {
Review comment:
this seems overly complex, could you construct the arrays in question
with JSON and then combine into a single test case that verifies all of the
statistics?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
