edponce commented on a change in pull request #10727:
URL: https://github.com/apache/arrow/pull/10727#discussion_r671353488
##########
File path: cpp/src/arrow/compute/api_scalar.cc
##########
@@ -357,6 +357,9 @@ SCALAR_ARITHMETIC_BINARY(Power, "power", "power_checked")
SCALAR_ARITHMETIC_BINARY(ShiftLeft, "shift_left", "shift_left_checked")
SCALAR_ARITHMETIC_BINARY(ShiftRight, "shift_right", "shift_right_checked")
SCALAR_EAGER_BINARY(Atan2, "atan2")
+SCALAR_EAGER_UNARY(Floor, "floor")
+SCALAR_EAGER_UNARY(Ceiling, "ceiling")
Review comment:
I used the short form for compute function names in this PR, and opened
[this JIRA](https://issues.apache.org/jira/projects/ARROW/issues/ARROW-13359)
to revisit the names of compute functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
