edponce commented on a change in pull request #10727:
URL: https://github.com/apache/arrow/pull/10727#discussion_r671411470
##########
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic_test.cc
##########
@@ -1032,47 +1032,90 @@ TEST(TestBinaryArithmetic,
AddWithImplicitCastsUint64EdgeCase) {
}
TEST(TestUnaryArithmetic, DispatchBest) {
- // All arithmetic
- for (std::string name : {"negate", "abs", "abs_checked", "sign"}) {
+ // All types (with _checked variant)
+ for (std::string name : {"abs"}) {
+ for (std::string suffix : {"", "_checked"}) {
+ name += suffix;
+ for (const auto& ty : {int8(), int16(), int32(), int64(), uint8(),
uint16(),
+ uint32(), uint64(), float32(), float64()}) {
+ CheckDispatchBest(name, {ty}, {ty});
+ CheckDispatchBest(name, {dictionary(int8(), ty)}, {ty});
+ }
+ }
+ }
+
+ // All types
+ for (std::string name : {"negate", "sign"}) {
for (const auto& ty : {int8(), int16(), int32(), int64(), uint8(),
uint16(), uint32(),
uint64(), float32(), float64()}) {
CheckDispatchBest(name, {ty}, {ty});
CheckDispatchBest(name, {dictionary(int8(), ty)}, {ty});
}
}
- // Signed arithmetic
+ // Fail on null type (with _checked variant)
+ for (std::string name : {"negate", "abs", "ln", "log2", "log10", "log1p",
"sin", "cos",
+ "tan", "asin", "acos"}) {
+ for (std::string suffix : {"", "_checked"}) {
+ name += suffix;
+ CheckDispatchFails(name, {null()});
+ }
+ }
+
+ // Fail on null type
+ for (std::string name : {"atan", "sign", "floor", "ceil", "trunc"}) {
+ CheckDispatchFails(name, {null()});
+ }
+
+ // Signed types
for (std::string name : {"negate_checked"}) {
for (const auto& ty : {int8(), int16(), int32(), int64(), float32(),
float64()}) {
CheckDispatchBest(name, {ty}, {ty});
CheckDispatchBest(name, {dictionary(int8(), ty)}, {ty});
}
}
- // Null input
- for (std::string name : {"negate", "negate_checked", "abs", "abs_checked",
"sign"}) {
- CheckDispatchFails(name, {null()});
- }
-
+ // Float types (with _checked variant)
for (std::string name :
{"ln", "log2", "log10", "log1p", "sin", "cos", "tan", "asin", "acos"}) {
for (std::string suffix : {"", "_checked"}) {
name += suffix;
+ for (const auto& ty : {float32(), float64()}) {
+ CheckDispatchBest(name, {ty}, {ty});
+ CheckDispatchBest(name, {dictionary(int8(), ty)}, {ty});
+ }
+ }
+ }
- CheckDispatchBest(name, {int32()}, {float64()});
- CheckDispatchBest(name, {uint8()}, {float64()});
+ // Float types
+ for (std::string name : {"atan", "floor", "ceil", "trunc"}) {
+ for (const auto& ty : {float32(), float64()}) {
+ CheckDispatchBest(name, {ty}, {ty});
+ CheckDispatchBest(name, {dictionary(int8(), ty)}, {ty});
+ }
+ }
- CheckDispatchBest(name, {dictionary(int8(), int64())}, {float64()});
+ // Integer -> Float64 (with _checked variant)
+ for (std::string name :
+ {"ln", "log2", "log10", "log1p", "sin", "cos", "tan", "asin", "acos"}) {
+ for (std::string suffix : {"", "_checked"}) {
+ name += suffix;
+ for (const auto& ty :
+ {int8(), int16(), int32(), int64(), uint8(), uint16(), uint32(),
uint64()}) {
+ CheckDispatchBest(name, {ty}, {float64()});
+ CheckDispatchBest(name, {dictionary(int8(), ty)}, {float64()});
+ }
}
}
- CheckDispatchBest("atan", {int32()}, {float64()});
- CheckDispatchBest("atan2", {int32(), float64()}, {float64(), float64()});
- CheckDispatchBest("atan2", {int32(), uint8()}, {float64(), float64()});
- CheckDispatchBest("atan2", {int32(), null()}, {float64(), float64()});
- CheckDispatchBest("atan2", {float32(), float64()}, {float64(), float64()});
- // Integer always promotes to double
- CheckDispatchBest("atan2", {float32(), int8()}, {float64(), float64()});
+ // Integer -> Float64
+ for (std::string name : {"atan", "floor", "ceil", "trunc"}) {
+ for (const auto& ty :
+ {int8(), int16(), int32(), int64(), uint8(), uint16(), uint32(),
uint64()}) {
+ CheckDispatchBest(name, {ty}, {float64()});
+ CheckDispatchBest(name, {dictionary(int8(), ty)}, {float64()});
+ }
+ }
Review comment:
Thanks for catching this, I had moved `atan2` to the binary
`DispatchBest` but apparently skipped it during a rebase/merge. I will add them
back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
