westonpace commented on a change in pull request #10729:
URL: https://github.com/apache/arrow/pull/10729#discussion_r671593084
##########
File path: cpp/src/parquet/statistics.h
##########
@@ -291,6 +291,9 @@ class TypedStatistics : public Statistics {
/// arrow::BinaryArray
virtual void Update(const ::arrow::Array& values) = 0;
+ virtual void UpdateArrowDictionary(const ::arrow::Array& indices,
Review comment:
I ended up just exposing `IncrementNullCount` and `IncrementNumValues`
and then added `bool update_counts` to `Update`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
