westonpace commented on a change in pull request #10729:
URL: https://github.com/apache/arrow/pull/10729#discussion_r671594372
##########
File path: cpp/src/parquet/column_writer.cc
##########
@@ -1490,7 +1490,8 @@ Status TypedColumnWriterImpl<DType>::WriteArrowDictionary(
// TODO(wesm): If some dictionary values are unobserved, then the
Review comment:
I've deleted the comment but I don't yet understand the point about
WriteIndicesChunk. I will need to look at this again later. Is it a
performance concern (don't make these extra allocations for the entire array
all at once but make the extra allocations many times at the batch level to
avoid total memory use) or is it a functional concern (maybe statistics are
stored on a per-batch basis?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
