rok edited a comment on pull request #11026:
URL: https://github.com/apache/arrow/pull/11026#issuecomment-910863287


   I tried adding `WeekOptions` with the following parameters:
   ```
     /// What day does the week start with (Monday=true, Sunday=false)
     bool week_starts_monday;
     /// Days in current year that fall into last years ISO week return week 0 
if true
     bool count_from_zero;
     /// Is the first week fully in the the year or only its 4 or more days
     bool first_week_in_year;
   ```
   
   I've also added tests with all the MySQL modes. Docs and the logic need some 
more work, but first: do we go this way or stick to iso week only? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to