lidavidm commented on pull request #11026: URL: https://github.com/apache/arrow/pull/11026#issuecomment-911667355
I think having the options for compatibility is good. A few questions, though: - For the first parameter, would it be a lot of work to allow any day of the week to be the start? It seems odd to have this be a boolean. - The second parameter's doc is a little confusing, what is the behavior if false? - The third parameter's naming is a little confusing - maybe 'first_week_is_full_week' or something? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
