rok commented on a change in pull request #11075:
URL: https://github.com/apache/arrow/pull/11075#discussion_r702040864
##########
File path: cpp/src/arrow/compute/kernels/scalar_temporal.cc
##########
@@ -466,8 +492,90 @@ struct Nanosecond {
// Convert timestamps to a string representation with an arbitrary format
#ifndef _WIN32
-template <typename Duration>
+template <typename Duration, typename InType>
struct Strftime {
Review comment:
> Actually, given that the regular strftime kernel won't format
timestamps without timezones, I wonder if it's meaningful to have strftime work
on dates.
There's work to have Strftime work on timestamps without timezones (assuming
UTC)
https://github.com/apache/arrow/pull/10998. It's a philosophical discussion
if it's correct or not but it will be available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
