aucahuasi commented on a change in pull request #11075:
URL: https://github.com/apache/arrow/pull/11075#discussion_r703105055
##########
File path: cpp/src/arrow/compute/kernels/scalar_temporal.cc
##########
@@ -588,8 +701,58 @@ inline std::array<int64_t, 3> GetIsoCalendar(int64_t arg,
Localizer&& localizer)
static_cast<int64_t>(weekday(ymd).iso_encoding())};
}
-template <typename Duration>
+template <typename Duration, typename InType>
struct ISOCalendar {
Review comment:
@lidavidm I think this last version reuse the kernel logic and it
specializes only the parts related to the timestamp logic. Please let me know
if if good enough.
TODO: I need to fix the some R tests (I'll tackle this tomorrow)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
