lidavidm commented on a change in pull request #11075:
URL: https://github.com/apache/arrow/pull/11075#discussion_r702052328
##########
File path: cpp/src/arrow/compute/kernels/scalar_temporal.cc
##########
@@ -466,8 +492,90 @@ struct Nanosecond {
// Convert timestamps to a string representation with an arbitrary format
#ifndef _WIN32
-template <typename Duration>
+template <typename Duration, typename InType>
struct Strftime {
Review comment:
Sorry for the back-and-forth @aucahuasi. However, it might be prudent to
split strftime support into a separate JIRA to minimize conflicts with the
existing PR and so we can evaluate how best to share the implementation (to
avoid too much code duplication).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
