lidavidm commented on a change in pull request #11075:
URL: https://github.com/apache/arrow/pull/11075#discussion_r702132912
##########
File path: cpp/src/arrow/compute/kernels/scalar_temporal.cc
##########
@@ -466,8 +492,90 @@ struct Nanosecond {
// Convert timestamps to a string representation with an arbitrary format
#ifndef _WIN32
-template <typename Duration>
+template <typename Duration, typename InType>
struct Strftime {
Review comment:
I don't think there's a JIRA so please do file one.
##########
File path: cpp/src/arrow/compute/kernels/scalar_temporal.cc
##########
@@ -588,8 +701,58 @@ inline std::array<int64_t, 3> GetIsoCalendar(int64_t arg,
Localizer&& localizer)
static_cast<int64_t>(weekday(ymd).iso_encoding())};
}
-template <typename Duration>
+template <typename Duration, typename InType>
struct ISOCalendar {
Review comment:
It would go in this file, though FWIW, it would probably be easiest to
just factor things into functions since these are all static methods anyways.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
