alamb commented on a change in pull request #849:
URL: https://github.com/apache/arrow-rs/pull/849#discussion_r734962112
##########
File path: arrow/src/csv/writer.rs
##########
@@ -241,7 +241,7 @@ impl<W: Write> Writer<W> {
.value_as_datetime(row_index)
.unwrap(),
};
- format!("{}", datetime.format(&self.timestamp_format))
+ format!("{}Z", datetime.format(&self.timestamp_format))
Review comment:
While this change does write out all timestamps as UTC, it effectively
ignores the timezone that is encoded in the `DataType::Timestamp(..)` unit. So
even if the timestamp had some other declared timezone this code will write it
out as though it were UTC
Would it be possible to use `value_as_datetime_with_tz` instead here ?
Following the model in the `hour` kernel?
https://sourcegraph.com/github.com/apache/arrow-rs/-/blob/arrow/src/compute/kernels/temporal.rs?L112-120&subtree=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
