novemberkilo commented on a change in pull request #849:
URL: https://github.com/apache/arrow-rs/pull/849#discussion_r735413817
##########
File path: arrow/src/csv/writer.rs
##########
@@ -241,7 +241,7 @@ impl<W: Write> Writer<W> {
.value_as_datetime(row_index)
.unwrap(),
};
- format!("{}", datetime.format(&self.timestamp_format))
+ format!("{}Z", datetime.format(&self.timestamp_format))
Review comment:
Thanks @alamb and @bjchambers for your feedback.
I'd like to do the following now:
1. Use the feature flag `chrono-tz` (because the kernel support for
extracting a FixedOffset from a String is also under this feature flag)
2. Proceed to implement:
> at a minimum we should validate that Timezone is None before defaulting it
to UTC (and thus adding a Z). When the Timezone is not None, we write out an
ISO8601 complaint representation. For example, if The Timezone is
"Australia/Sydney" then the string includes "+11:00" (well, when DST is in
effect anyway).
Confirming that this sounds reasonable? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
