novemberkilo commented on a change in pull request #849:
URL: https://github.com/apache/arrow-rs/pull/849#discussion_r735082128
##########
File path: arrow/src/csv/writer.rs
##########
@@ -241,7 +241,7 @@ impl<W: Write> Writer<W> {
.value_as_datetime(row_index)
.unwrap(),
};
- format!("{}", datetime.format(&self.timestamp_format))
+ format!("{}Z", datetime.format(&self.timestamp_format))
Review comment:
Thanks @alamb - have thought about this a bit and I'd like to please
confirm that if the Timezone is declared in the schema, then it is reflected in
the string representation of the timestamp (following ISO8601).
In other words, the CSV writer will _always include the Timezone_ in
timestamps (defaulting to UTC in the case of no Timezone specified).
Separately, I am also curious about the expected behaviour of the reader
vis-à-vis timezone information. If the schema for a column declares a timezone
(say America/New_York), and the data in that column has an offset for some
other timezone (say 2010-01-31T10:30:00+11:00), what should the reader do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
