lidavidm commented on a change in pull request #11674:
URL: https://github.com/apache/arrow/pull/11674#discussion_r748975667
##########
File path: cpp/src/arrow/array/array_nested.cc
##########
@@ -680,7 +680,7 @@ Result<std::shared_ptr<Array>>
SparseUnionArray::GetFlattenedField(
if (child_null_bitmap) {
BitmapAnd(flattened_null_bitmap->data(), child_offset,
child_null_bitmap->data(),
child_offset, child_data->length, child_offset,
- flattened_null_bitmap->mutable_data());
+ flattened_null_bitmap->mutable_data(), /*out pop count*/
nullptr);
Review comment:
It should not be a problem. One, we make use of default parameters quite
extensively already, and if we need a binding, we can handle it appropriately
(if needed with an "extern C" though I don't think we need resort to that).
Two, this function is mostly used internally and is unlikely to be used by a
binding (and it's in the ::internal namespace anyways).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
