iajoiner commented on a change in pull request #12231:
URL: https://github.com/apache/arrow/pull/12231#discussion_r790289895
##########
File path: cpp/src/arrow/adapters/orc/adapter.cc
##########
@@ -720,11 +720,7 @@ class ArrowOutputStream : public liborc::OutputStream {
return filename;
}
- void close() override {
- if (!output_stream_.closed()) {
- ORC_THROW_NOT_OK(output_stream_.Close());
- }
- }
+ void close() override {}
Review comment:
What ORC does is writing the content. Then it attempts to close the
`liborc::OutputStream.`
https://github.com/apache/orc/blob/7e12a8ccac81548fde6e5d0538da2e68c77df601/c%2B%2B/src/Writer.cc#L369
The issue here is of course that we shouldn’t actually close the
`arrow::io::OutputStream` because at least in some instances (such as when we
are using `io.BytesIO`) we don’t exactly want it closed right after the
flushing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
