pitrou commented on a change in pull request #12231:
URL: https://github.com/apache/arrow/pull/12231#discussion_r790547496
##########
File path: python/pyarrow/_orc.pyx
##########
@@ -388,8 +388,11 @@ cdef class ORCWriter(_Weakrefable):
object sink
unique_ptr[ORCFileWriter] writer
shared_ptr[COutputStream] rd_handle
Review comment:
Can you take the opportunity to rename this? The name is obviously wrong.
##########
File path: python/pyarrow/_orc.pyx
##########
@@ -403,6 +406,7 @@ cdef class ORCWriter(_Weakrefable):
cdef:
shared_ptr[WriteOptions] write_options
self.sink = sink
+ self.close_file = close_file
Review comment:
If `sink` is not a file object but e.g. a file path, the file should
always be closed at the end, however.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
