jorisvandenbossche commented on a change in pull request #12231:
URL: https://github.com/apache/arrow/pull/12231#discussion_r790761904
##########
File path: python/pyarrow/_orc.pyx
##########
@@ -388,8 +388,11 @@ cdef class ORCWriter(_Weakrefable):
object sink
unique_ptr[ORCFileWriter] writer
shared_ptr[COutputStream] rd_handle
Review comment:
For reference, in the cython ParquetWriter, we have
```
shared_ptr[COutputStream] sink
bint own_sink
```
and this `own_sink` is defined based on the input sink (file path we open
ourselves vs already open file-like object-, and the use that to determine
whether `close()` should close it or not.
We can maybe follow similar pattern here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
