jorisvandenbossche commented on a change in pull request #12231:
URL: https://github.com/apache/arrow/pull/12231#discussion_r790763779
##########
File path: python/pyarrow/_orc.pyx
##########
@@ -403,6 +406,7 @@ cdef class ORCWriter(_Weakrefable):
cdef:
shared_ptr[WriteOptions] write_options
self.sink = sink
+ self.close_file = close_file
Review comment:
See my comment above about how the parquet cython code handles this:
https://github.com/apache/arrow/blob/daa5c18e9697a6455a7a75fec19594543c17b21e/python/pyarrow/_parquet.pyx#L1450-L1459
and
https://github.com/apache/arrow/blob/daa5c18e9697a6455a7a75fec19594543c17b21e/python/pyarrow/_parquet.pyx#L1486-L1491
That also avoids that this keyword needs to be propagated to the public API
(as Antoine mentions, the fixed default of False (or True) would not be correct
in all cases)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
