iajoiner commented on pull request #12231: URL: https://github.com/apache/arrow/pull/12231#issuecomment-1020775124
@pitrou @jorisvandenbossche Really thanks for the suggestions! I have fix them as well as the following issues: 1. Naming and ordering of some ORC readwrite tests. I renamed tests that write to a `pa.Buffer` as opposed to an actual ORC file "buffer", leaving "orcfile" tests for tests that do write to ORC files. 2. Per @jorisvandenbossche 's suggestion after https://github.com/apache/arrow/pull/9702 was merged I found that `compression_block_size` and `stripe_size` are in bytes. Hence I clarified the docs in both C++ and Python. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
