robertwb commented on a change in pull request #11221: Add base SDK version to
environment capabilities for Python and Java.
URL: https://github.com/apache/beam/pull/11221#discussion_r398735979
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/Environments.java
##########
@@ -239,6 +239,7 @@ public static Environment createProcessEnvironment(
capabilities.addAll(ModelCoders.urns());
capabilities.add(BeamUrns.getUrn(StandardProtocols.Enum.MULTI_CORE_BUNDLE_PROCESSING));
capabilities.add(BeamUrns.getUrn(StandardProtocols.Enum.PROGRESS_REPORTING));
+ capabilities.add("beam:version:sdk_base:" +
JAVA_SDK_HARNESS_CONTAINER_URL);
Review comment:
I did this because the languages might be versioned as well (as they are in
Python, and may be in Java). This version may not align precisely with the
version used during construction, but the default container should always be
compatible with it to whatever level of granularity our containers are build. I
also don't think we should be encourage any branching on `beam:sdk:version`.
However, if you feel strongly we could split these out.
Adding a generic marker for go.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
