robertwb commented on a change in pull request #11221: [BEAM-9614] Add base SDK
version to environment capabilities for Python, Java and initial value for Go
URL: https://github.com/apache/beam/pull/11221#discussion_r398817446
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/Environments.java
##########
@@ -239,6 +239,7 @@ public static Environment createProcessEnvironment(
capabilities.addAll(ModelCoders.urns());
capabilities.add(BeamUrns.getUrn(StandardProtocols.Enum.MULTI_CORE_BUNDLE_PROCESSING));
capabilities.add(BeamUrns.getUrn(StandardProtocols.Enum.PROGRESS_REPORTING));
+ capabilities.add("beam:version:sdk_base:" +
JAVA_SDK_HARNESS_CONTAINER_URL);
Review comment:
Yeah, we can't rule out people trying to parse these, but at least then
they'll know they're on shaky ground. And as you say, these aren't terribly
sticky. (I hope we never have to use them.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
