damccorm commented on PR #26793: URL: https://github.com/apache/beam/pull/26793#issuecomment-1556231273
I'd rather not do this for 2 reasons: 1) It will take ~5 minutes to compute the changes (because of the changes to mass_comment.py, so this approach is much faster (<1 min for everything else) 2) I think its generally a bad idea to silently succeed in situations like this if there are no changes. That often could mean you did something unexpected like mistyping the version number. We could add logic to account for some of that, but it ups the complexity for limited reward. I'd prefer to just fail in those cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
